Messages in this thread | | | From | David Brownell <> | Subject | Re: [rtc-linux] [PATCH 2/2] rtc: rtc-wm8350: Add support for WM8350 RTC | Date | Mon, 27 Oct 2008 13:19:34 -0700 |
| |
On Monday 27 October 2008, Mark Brown wrote: > On Mon, Oct 27, 2008 at 01:03:21PM -0700, David Brownell wrote: > > On Monday 27 October 2008, Alessandro Zummo wrote: > > > (and a detailed checklist at http://groups.google.com/group/rtc-linux/web/checklist ) > > > Also: rtc_ops.ioctl() method should only handle RTC_{AIE,UIE}_{ON,OFF}, > > since the other standard ioctls have rtc_ops equivalents. > > > (This code is fine in both respects. Though since I've received three > > copies of the driver since it was merged to MM, maybe I missed something.) > > Unfortunately I added the __devexit_p() annotation in response to > Alessandro's comments. I'll remove it again,
No, don't -- that's why I said "this code is fine..." !!
You're not using platform_driver_probe(), so it's appropriate to use the __devexit() route.
> other than that all that's > changed is a tweak to the module description and Andrew's change to use > schedule_timeout_uninterruptible(). > > How should these drivers be merged?
Andrew is the keeper of the RTC patch queue, so I suggest you issue one patch against the two in MM:
rtc-rtc-wm8350-add-support-for-wm8350-rtc.patch rtc-rtc-wm8350-add-support-for-wm8350-rtc-fix.patch
That would probably cause the least amount of extra work for Andrew.
- Dave
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |