Messages in this thread | | | From | David Brownell <> | Subject | Re: [rtc-linux] [PATCH 2/2] rtc: rtc-wm8350: Add support for WM8350 RTC | Date | Mon, 27 Oct 2008 13:03:21 -0700 |
| |
On Monday 27 October 2008, Alessandro Zummo wrote: > (and a detailed checklist at http://groups.google.com/group/rtc-linux/web/checklist )
The comment about probe()/__devinit and remove()/__devexit/__devexit_p isn't right ... when the driver uses platform_driver_probe(), the "__dev" variants should not be used. (It's a Good Thing to shrink runtime code footprints, by using platform_driver_probe for non-hotpluggable devices.)
Also: rtc_ops.ioctl() method should only handle RTC_{AIE,UIE}_{ON,OFF}, since the other standard ioctls have rtc_ops equivalents.
(This code is fine in both respects. Though since I've received three copies of the driver since it was merged to MM, maybe I missed something.)
- Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |