lkml.org 
[lkml]   [2008]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2 v3] SGI RTC: add RTC system interrupt
On Mon, Oct 27, 2008 at 03:08:29PM +0100, Ingo Molnar wrote:
>
> * Dimitri Sivanich <sivanich@sgi.com> wrote:
>
> > +void uv_rtc_timer_interrupt(struct pt_regs *regs)
> > +{
> > + struct pt_regs *old_regs = set_irq_regs(regs);
> > +
> > + ack_APIC_irq();
> > +
> > + exit_idle();
> > +
> > + irq_enter();
> > +
> > + if (uv_rtc_interrupt_extension)
> > + uv_rtc_interrupt_extension();
> > +
> > + irq_exit();
> > +
> > + set_irq_regs(old_regs);
> > +}
>
> hm, the exit_idle() looks weird - why is it done? If we get an IRQ
> then the CPU will exit idle state anyway.

Ingo,

I'm not quite sure what you mean here. Are you referring to an explicit call to exit_idle() that is done somewhere else (such as do_IRQ())?


\
 
 \ /
  Last update: 2008-10-27 16:33    [W:0.101 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site