lkml.org 
[lkml]   [2008]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2 v3] SGI RTC: add RTC system interrupt

* Dimitri Sivanich <sivanich@sgi.com> wrote:

> +void uv_rtc_timer_interrupt(struct pt_regs *regs)
> +{
> + struct pt_regs *old_regs = set_irq_regs(regs);
> +
> + ack_APIC_irq();
> +
> + exit_idle();
> +
> + irq_enter();
> +
> + if (uv_rtc_interrupt_extension)
> + uv_rtc_interrupt_extension();
> +
> + irq_exit();
> +
> + set_irq_regs(old_regs);
> +}

hm, the exit_idle() looks weird - why is it done? If we get an IRQ
then the CPU will exit idle state anyway.

Ingo


\
 
 \ /
  Last update: 2008-10-27 15:11    [W:0.065 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site