lkml.org 
[lkml]   [2008]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Avoid I/O errors when issuing SCSI ioctls to JMicron USB/ATA bridge
Alexandre Oliva wrote:
> Here's the patch that implements the fix you suggested to avoid the
> I/O errors that I was running into with my new USB enclosure with a
> JMicron USB/ATA bridge, while issuing scsi-io USN or other such
> queries used by Fedora's mkinitrd.
> http://bugzilla.kernel.org/show_bug.cgi?id=9638#c85

Alexandre,

The patch looks generally good, but you've included every possible revision
of the hardware. Can you please change your patch to include just the
revision in question (0x0100) rather than the whole range (0x0000 - 0x9999)?

Thanks.
--
Phil Dibowitz phil@ipom.com
Open Source software and tech docs Insanity Palace of Metallica
http://www.phildev.net/ http://www.ipom.com/

"Never write it in C if you can do it in 'awk';
Never do it in 'awk' if 'sed' can handle it;
Never use 'sed' when 'tr' can do the job;
Never invoke 'tr' when 'cat' is sufficient;
Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming


[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2008-10-14 21:53    [W:0.035 / U:1.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site