Messages in this thread | | | Date | Sun, 27 Jan 2008 02:48:53 +0300 | From | Dmitri Vorobiev <> | Subject | Re: [PATCH v2 8/9] bfs: remove multiple assignments |
| |
Tigran Aivazian wrote: > On Sat, 26 Jan 2008, Dmitri Vorobiev wrote: >> - inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME_SEC; >> + inode->i_mtime = CURRENT_TIME_SEC; >> + inode->i_atime = CURRENT_TIME_SEC; >> + inode->i_ctime = CURRENT_TIME_SEC; > > multiple assignments like "x = y = z = value;" can potentially > (depending on the compiler and arch) be faster than "x = value; y = > value; z=value;" > > I am surprized that this script complains about them as it is a > perfectly valid thing to do in C.
I think it seems wise to ask the maintainers of checkpatch.pl to comment on that. I'm Cc:ing them now.
Thanks,
Dmitri
| |