Messages in this thread | | | Subject | Re: [PATCH 04/27] kill filp_open() | From | Dave Hansen <> | Date | Wed, 16 Jan 2008 09:41:12 -0800 |
| |
On Wed, 2008-01-16 at 17:10 +0000, Christoph Hellwig wrote: > > But ultimatively I think we should remove this silly renaming from > the patch. It doesn't help the goal and just created churn, so please > rename open_namei back to do_filp_open for now and put filp_open back.
It wasn't really a rename. More that I ended up moving everything useful the filp_open() did to other functions, so I didn't see the need to keep around a stub like this:
struct file *filp_open(const char *filename, int flags, int mode) { return open_namei(AT_FDCWD, filename, flags, mode); }
It would be trivial to add this stub back, though.
-- Dave
| |