Messages in this thread | | | Date | Wed, 16 Jan 2008 17:10:32 +0000 | From | Christoph Hellwig <> | Subject | Re: [PATCH 04/27] kill filp_open() |
| |
On Wed, Jan 16, 2008 at 09:04:56AM -0800, Dave Hansen wrote: > > is using filp_open() and hence doesn't work very well. > > > > A shall revert dm-loop.patch and run away. > > This one's pretty easy, thank goodness. Just replace filp_open() with > open_namei(): > > /filp_open(/open_namei(AT_FDCWD, /
But ultimatively I think we should remove this silly renaming from the patch. It doesn't help the goal and just created churn, so please rename open_namei back to do_filp_open for now and put filp_open back.
> BTW, why do we need this on top of the existing loopback driver? Can > they really share no code?
Yeah, given how much pain loop drivers in general are I don't think it's a good idea to add a second one.
| |