Messages in this thread Patch in this message | | | Date | Mon, 14 Jan 2008 23:08:05 +0200 | From | Adrian Bunk <> | Subject | libata-scsi.c: new check-after-use |
| |
Commit 9b8e8de7e59b3a2dab3113d620b52dc8ba890fb3 did:
--- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -872,7 +872,8 @@ int ata_scsi_slave_config(struct scsi_device *sdev) ata_scsi_sdev_config(sdev); - sdev->manage_start_stop = 1; + if (dev->class == ATA_DEV_ATA) + sdev->manage_start_stop = 1; if (dev) ata_scsi_dev_config(sdev, dev);
The Coverity checker spotted that this introduced a check-after-use for "dev".
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
| |