lkml.org 
[lkml]   [2008]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH 2/2] checkstack: fix perl warnings
If you enable perl warnings on this script, it shows a couple of problems:

Parentheses missing around "my" list at scripts/checkstack.pl line 105.
Useless use of a variable in void context at scripts/checkstack.pl line 105.
Use of uninitialized value in string eq at scripts/checkstack.pl line 33.

Signed-off-by: Stephen Hemminger <stephen.hemminger@vyatta.com>

--- a/scripts/checkstack.pl 2008-01-14 11:10:57.000000000 -0800
+++ b/scripts/checkstack.pl 2008-01-14 11:11:56.000000000 -0800
@@ -30,7 +30,7 @@
my (@stack, $re, $x, $xs);
{
my $arch = shift;
- if ($arch eq "") {
+ if (! defined $arch) {
$arch = `uname -m`;
chomp $arch;
}
@@ -102,7 +102,8 @@ sub bysize($) {
#
my $funcre = qr/^$x* <(.*)>:$/;
my $func;
-my $file, $lastslash;
+my $file;
+my $lastslash;

while (my $line = <STDIN>) {
if ($line =~ m/$funcre/) {

\
 
 \ /
  Last update: 2008-01-14 20:25    [W:0.048 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site