Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH 14/21] ide-floppy: mv idefloppy_{should_,}report_error | Date | Sat, 12 Jan 2008 21:16:31 +0100 |
| |
On Friday 11 January 2008, Borislav Petkov wrote: > In addition to shortening the function name, move the printk-call into the > function thereby saving some code lines. Also, make the function out_of_line > since it is not on a performance critical path. > > Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de> > --- > drivers/ide/ide-floppy.c | 37 ++++++++++++++----------------------- > 1 files changed, 14 insertions(+), 23 deletions(-) > > diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c > index 49d83a1..b718615 100644 > --- a/drivers/ide/ide-floppy.c > +++ b/drivers/ide/ide-floppy.c > @@ -707,16 +707,18 @@ static ide_startstop_t idefloppy_transfer_pc1(ide_drive_t *drive) > return ide_started; > } > > -/* > - * Suppresses error messages resulting from Medium not present. > - */ > -static inline int idefloppy_should_report_error(idefloppy_floppy_t *floppy) > +static void idefloppy_report_error(idefloppy_floppy_t *floppy, > + idefloppy_pc_t *pc) > {
-> Would make a sense to move the comment here instead of removing it (it is useful unless you remeber all ->{sense_key,asc,ascq} value).
> if (floppy->sense_key == 0x02 && > floppy->asc == 0x3a && > floppy->ascq == 0x00) > - return 0; > - return 1; > + return;
Otherwise the patch is fine.
| |