lkml.org 
[lkml]   [2008]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 20/21] ide-floppy: merge idefloppy_{input,output}_buffers
    Date
    On Friday 11 January 2008, Borislav Petkov wrote:
    > We merge idefloppy_{input,output}_buffers() into idefloppy_io_buffers() by
    > introducing a 4th arg. called direction. According to its value
    > we atapi_input_bytes() or atapi_output_bytes(). Also, simplify the interrupt

    This change is fine but ...

    > handler by removing multiple calls testing the data direction and using a local
    > variable instead.

    ... the patch replaces 'test_bit(PC_WRITING, &pc->flags)' check with
    'rq_data_dir(rq) == WRITE' one. While this may look as "trivial" change it
    is not such. It should be done only after auditing the driver and making
    sure that we are not introducing subtle regressions (=> I see that some
    commands are setting PC_WRITING but are not setting REQ_RW bit), especially
    given that these changes were not tested with the real hardware.

    Please separate this change to another (post-)patch.

    PS It would also be nice to remove IDEFLOPPY_DEBUG_BUGS define in a pre-patch.


    \
     
     \ /
      Last update: 2008-01-12 21:25    [W:2.517 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site