lkml.org 
[lkml]   [2008]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH/RFC] synchronize_rcu(): high latency on idle system
Date
On Saturday 12 January 2008 18:51:35 Benjamin LaHaise wrote:
> On Sat, Jan 12, 2008 at 03:37:59AM +0100, Andi Kleen wrote:
> > > And yes, the
> > > network stack shouldn't call synchronize_rcu() quite so much, but fixing that
> > > is a little more involved.
> >
> > ... but the correct solution.
>
> There has to be at least 1 synchronize_rcu() or equivalent in the
> unregister_netdev() path. I suspect the easiest way to fix it might be to
> use call_rcu() to actually free the network device, as anything else will
> limit performance of single threaded teardown (ie, when an l2tp daemon
> gets terminated via kill -9). This means an API change that exposes
> rcu for unregister_netdev().

The call_rcu() could be in free_netdev() couldn't it?

-Andi


\
 
 \ /
  Last update: 2008-01-12 19:41    [W:0.093 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site