lkml.org 
[lkml]   [2008]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH/RFC] synchronize_rcu(): high latency on idle system
On Sat, Jan 12, 2008 at 03:37:59AM +0100, Andi Kleen wrote:
> > And yes, the
> > network stack shouldn't call synchronize_rcu() quite so much, but fixing that
> > is a little more involved.
>
> ... but the correct solution.

There has to be at least 1 synchronize_rcu() or equivalent in the
unregister_netdev() path. I suspect the easiest way to fix it might be to
use call_rcu() to actually free the network device, as anything else will
limit performance of single threaded teardown (ie, when an l2tp daemon
gets terminated via kill -9). This means an API change that exposes
rcu for unregister_netdev().

-ben
--
"Time is of no importance, Mr. President, only life is important."
Don't Email: <zyntrop@kvack.org>.


\
 
 \ /
  Last update: 2008-01-12 18:55    [W:0.043 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site