Messages in this thread | | | Date | Thu, 10 Jan 2008 20:29:50 +0100 | From | Andi Kleen <> | Subject | Re: [patch 1/1] Switch ioctl functions of drivers/scsi/sg.c to unlocked_ioctl |
| |
On Thu, Jan 10, 2008 at 08:07:48PM +0100, Andre Noll wrote: > On 19:59, Andi Kleen wrote: > > > But perhaps for such a long ioctl handler it would be better to move > > the lock/unlock_kernel()s into the individual case ...: statements; > > then it could be eliminated step by step. > > Sure, I can do that if James likes the idea. Since not all case > statements need the BKL, we could add it only to those for which it > isn't clear that it is unnecessary. > > And this would actually improve something.
I still think it would be a good strategy to first add it to all (in a essentially nop semantics patch) and then later eliminate it from the cases that obviously don't need it.
But yes eliminating it from all is the long term goal.
-Andi
| |