Messages in this thread | | | Date | Wed, 26 Sep 2007 07:33:07 +0530 | From | Dhaval Giani <> | Subject | Re: [PATCH 1/3] Fix coding style |
| |
On Tue, Sep 25, 2007 at 09:16:20PM +0200, Ingo Oeser wrote: > On Tuesday 25 September 2007, Srivatsa Vaddagiri wrote: > > Index: current/kernel/sched_debug.c > > =================================================================== > > --- current.orig/kernel/sched_debug.c > > +++ current/kernel/sched_debug.c > > @@ -239,11 +239,7 @@ static int > > root_user_share_read_proc(char *page, char **start, off_t off, int count, > > int *eof, void *data) > > { > > - int len; > > - > > - len = sprintf(page, "%d\n", init_task_grp_load); > > - > > - return len; > > + return sprintf(page, "%d\n", init_task_grp_load); > > } > > > > static int > > @@ -297,7 +293,7 @@ static int __init init_sched_debug_procf > > pe->proc_fops = &sched_debug_fops; > > > > #ifdef CONFIG_FAIR_USER_SCHED > > - pe = create_proc_entry("root_user_share", 0644, NULL); > > + pe = create_proc_entry("root_user_cpu_share", 0644, NULL); > > if (!pe) > > return -ENOMEM; > > What about moving this debug stuff under debugfs? > Please consider using the functions in <linux/debugfs.h> . > They compile into nothing, if DEBUGFS is not compiled in > and have already useful functions for reading/writing integers > and booleans. > Hi Ingo,
This is not debug stuff. It is a tunable to give the root user more weight with respect to the other users.
-- regards, Dhaval - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |