lkml.org 
[lkml]   [2007]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/3] Fix coding style
Date
On Sep 25, 2007, at 15:16:20, Ingo Oeser wrote:
> On Tuesday 25 September 2007, Srivatsa Vaddagiri wrote:
>> @@ -297,7 +293,7 @@ static int __init init_sched_debug_procf
>> pe->proc_fops = &sched_debug_fops;
>>
>> #ifdef CONFIG_FAIR_USER_SCHED
>> - pe = create_proc_entry("root_user_share", 0644, NULL);
>> + pe = create_proc_entry("root_user_cpu_share", 0644, NULL);
>> if (!pe)
>> return -ENOMEM;
>
> What about moving this debug stuff under debugfs? Please consider
> using the functions in <linux/debugfs.h>. They compile into
> nothing, if DEBUGFS is not compiled in and have already useful
> functions for reading/writing integers and booleans.

Umm, that's not a debugging thing. It appears to be a tunable
allowing you to configure what percentage of the total CPU that UID 0
gets which is likely to be useful to configure on production systems;
at least until better group-scheduling tools are produced.

Cheers,
Kyle Moffett

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-09-25 22:51    [W:0.032 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site