lkml.org 
[lkml]   [2007]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[Patch] Fix panic of cpu online with memory less node

When a cpu is onlined on memory-less-node box, kernel panics due to
touch NULL pointer of pgdat->kswapd. Current kswapd runs only
nodes which have memory. So, calling of set_cpus_allowed()
is not necessary for memory-less node.

This is fix for it.


Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>

---
mm/vmscan.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Index: current/mm/vmscan.c
===================================================================
--- current.orig/mm/vmscan.c 2007-09-03 16:36:18.000000000 +0900
+++ current/mm/vmscan.c 2007-09-11 13:02:20.000000000 +0900
@@ -1843,9 +1843,11 @@ static int __devinit cpu_callback(struct
{
pg_data_t *pgdat;
cpumask_t mask;
+ int nid;

if (action == CPU_ONLINE || action == CPU_ONLINE_FROZEN) {
- for_each_online_pgdat(pgdat) {
+ for_each_node_state(nid, N_HIGH_MEMORY) {
+ pgdat = NODE_DATA(nid);
mask = node_to_cpumask(pgdat->node_id);
if (any_online_cpu(mask) != NR_CPUS)
/* One of our CPUs online: restore mask */
--
Yasunori Goto


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-09-11 12:23    [W:0.027 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site