Messages in this thread Patch in this message | | | From | Andreas Schwab <> | Subject | [PATCH] Pass nr_wake2 to futex_wake_op | Date | Sat, 07 Jul 2007 17:02:53 +0200 |
| |
The fourth argument of sys_futex is ignored when op == FUTEX_WAKE_OP, but futex_wake_op expects it as its nr_wake2 parameter.
The only user of this operation in glibc is always passing 1, so this bug had no consequences so far.
Signed-off-by: Andreas Schwab <schwab@suse.de>
--- kernel/futex.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
--- linux-2.6.22-rc7.orig/kernel/futex.c 2007-07-02 00:40:44.000000000 +0200 +++ linux-2.6.22-rc7/kernel/futex.c 2007-07-07 15:56:42.000000000 +0200 @@ -2061,8 +2061,10 @@ asmlinkage long sys_futex(u32 __user *ua } /* * requeue parameter in 'utime' if cmd == FUTEX_REQUEUE. + * number of waiters to wake in 'utime' if cmd == FUTEX_WAKE_OP. */ - if (cmd == FUTEX_REQUEUE || cmd == FUTEX_CMP_REQUEUE) + if (cmd == FUTEX_REQUEUE || cmd == FUTEX_CMP_REQUEUE || + cmd == FUTEX_WAKE_OP) val2 = (u32) (unsigned long) utime; return do_futex(uaddr, op, val, tp, uaddr2, val2, val3); -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |