Messages in this thread | | | Date | Sun, 1 Jul 2007 21:24:41 +0200 | From | Rodolfo Giometti <> | Subject | Re: [PATCH] LinuxPPS (with new syscalls API) - new version |
| |
On Sun, Jul 01, 2007 at 05:13:25PM +1000, Stephen Rothwell wrote: > On Sat, 30 Jun 2007 19:13:40 +0200 Rodolfo Giometti <giometti@enneenne.com> wrote: > > > > Maybe I can define a special struct for exchanging time data as: > > > > struct pps_timedata_s { > > long sec; > > long nsec; > > } > > > > and managing time data conversions at userland... > > > > What do you think about that? :) > > "long" is one of the datatypes that changes size between 32 bit and 64 > bit, so not such a good choice. You could use __u32 or __64 (or > whatever), that makes it very clear that these are fixed size data types.
struct pps_timedata_s { __32 sec; __32 nsec; }
Ok? I think 32 bits are enought for keeping seconds... :)
If you have no more advices I think I can start changing this part in order to avoid using struct timespec.
Ciao,
Rodolfo
--
GNU/Linux Solutions e-mail: giometti@enneenne.com Linux Device Driver giometti@gnudd.com Embedded Systems giometti@linux.it UNIX programming phone: +39 349 2432127 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |