Messages in this thread | | | Date | Sat, 30 Jun 2007 19:13:40 +0200 | From | Rodolfo Giometti <> | Subject | Re: [PATCH] LinuxPPS (with new syscalls API) - new version |
| |
On Fri, Jun 29, 2007 at 05:40:52PM +0100, David Woodhouse wrote: > > Remember you have to support _both_ 32-bit and 64-bit system calls. You > need to define struct compat_pps_info and struct compat_pps_params, and > you'll have to provide a compat wrapper for sys_time_pps_getparams() and > sys_time_pps_setparams(). You'll also need to extend your > compat_sys_time_pps_fetch() wrapper to handle the struct pps_info too.
At this point I'm seriously considfering your previous suggestion:
Had you considered changing the API so that you don't need the compatibility wrapper at all? Could you take an integer number of µS or ms instead of a struct timespec?
Maybe I can define a special struct for exchanging time data as:
struct pps_timedata_s { long sec; long nsec; }
and managing time data conversions at userland...
What do you think about that? :)
Thanks,
Rodolfo
--
GNU/Linux Solutions e-mail: giometti@enneenne.com Linux Device Driver giometti@gnudd.com Embedded Systems giometti@linux.it UNIX programming phone: +39 349 2432127 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |