Messages in this thread Patch in this message | | | Date | Fri, 08 Jun 2007 10:45:09 -0600 | From | dougthompson@xmission ... | Subject | [PATCH 3/6] driver edac fix ignored return i82875p |
| |
From: Douglas Thompson <dougthompson@xmission.com>
Compiling this module gave a warning that the return value of 'pci_bus_add_device()' was not checked.
This patch adds that check and an output message
Signed-off-by: Douglas Thompson <dougthompson@xmission.com> Cc: alan@lxorguk.ukuu.org.uk ---
Index: linux-2.6.22-rc4-mm1/drivers/edac/i82875p_edac.c =================================================================== --- linux-2.6.22-rc4-mm1.orig/drivers/edac/i82875p_edac.c +++ linux-2.6.22-rc4-mm1/drivers/edac/i82875p_edac.c @@ -270,6 +270,7 @@ static int i82875p_setup_overfl_dev(stru { struct pci_dev *dev; void __iomem *window; + int err; *ovrfl_pdev = NULL; *ovrfl_window = NULL; @@ -287,7 +288,12 @@ static int i82875p_setup_overfl_dev(stru if (dev == NULL) return 1; - pci_bus_add_device(dev); + err = pci_bus_add_device(dev); + if (err) { + i82875p_printk(KERN_ERR, + "%s(): pci_bus_add_device() Failed\n", + __func__); + } } *ovrfl_pdev = dev; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |