lkml.org 
[lkml]   [2007]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] Leak in eicon/idifunc.c
Hi,

coverity spotted a possible leak in the idifunc.c file (bug id #1252),
in um_new_card(), if the diva_user_mode_idi_create_adapter() fails,
we dont free the memory allocated for card

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Acked-by: Armin Schindler <armin@melware.de>

--- linux-2.6/drivers/isdn/hardware/eicon/idifunc.c.orig 2007-05-22 00:22:02.000000000 +0200
+++ linux-2.6/drivers/isdn/hardware/eicon/idifunc.c 2007-05-22 00:22:52.000000000 +0200
@@ -106,6 +106,7 @@ static void um_new_card(DESCRIPTOR * d)
} else {
DBG_ERR(("could not create user mode idi card %d",
adapter_nr));
+ diva_os_free(0, card);
}
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2007-06-07 16:43    [W:0.026 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site