lkml.org 
[lkml]   [2007]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: pci.h stubs (was: EDD build error)
On Wed, 27 Jun 2007 08:03:05 -0600
Matthew Wilcox <matthew@wil.cx> wrote:

> On Wed, Jun 27, 2007 at 02:55:00PM +0100, Alan Cox wrote:
> > On Wed, 27 Jun 2007 05:30:48 -0600
> > Matthew Wilcox <matthew@wil.cx> wrote:
> > > pci_get_bus_and_slot() shouldn't be used because it fails to work on
> > > systems with multiple domains. pci_get_slot() avoids this problem (and
> > > is much faster too).
> >
> > But requires you have a bus pointer to hand which is often not the
> > case. Do we need pci_get_domain_bus_and_slot() ?
>
> We have pci_find_bus(domain, busnr) which will get you the bus pointer.

So the answer is "yes" we should then, and move from pci_get_bus_and_slot
to pci_get_bus_domain_and_slot() [or just add an argument]. The point of
the functions is to be easy to use, so it should be handled internally.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-06-27 16:29    [W:0.047 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site