Messages in this thread | | | Subject | Re: [RFC PATCH 0/6] Convert all tasklets to workqueues | From | Steven Rostedt <> | Date | Fri, 22 Jun 2007 10:27:22 -0400 |
| |
On Fri, 2007-06-22 at 15:12 +0200, Ingo Molnar wrote: > * Steven Rostedt <rostedt@goodmis.org> wrote: >
> yes, the softirq based tasklet implementation with workqueue based > implementation, but the tasklet API itself should still stay.
done.
> > ok, enough idle talking, lets see the next round of patches? :)
Still need to run through testing, and I still don't have distcc working. So it may take a while ;-)
> > please remove all the pr_debug() lines as well - they are handy for > development but are quite unnecessary for something headed
done (but I did keep one).
> upstream-wards. And please replace all the BUG_ON()s with WARN_ON_ONCE()
I had two BUG_ON's and they were both for not having the ktaskletd_wq allocated. If we just put a WARN_ON, we will right afterward get a BUG from a bad memory reference, and put the system into an unknown state. Are you sure you still want me to convert them to WARN_ON?
-- Steve
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |