Messages in this thread | | | Subject | Re: [RFC PATCH 0/6] Convert all tasklets to workqueues | From | Steven Rostedt <> | Date | Fri, 22 Jun 2007 09:35:40 -0400 |
| |
On Fri, 2007-06-22 at 06:13 -0700, Andrew Morton wrote: > > On Fri, 22 Jun 2007 08:58:44 -0400 Steven Rostedt <rostedt@goodmis.org> wrote: > > On Fri, 2007-06-22 at 14:38 +0200, Ingo Molnar wrote: > > > * Steven Rostedt <rostedt@goodmis.org> wrote:
> > > > Honestly, I highly doubted that this would make it up to Linus's tree. > > > > > > that's where it belongs - but it first needs the cleanups suggested by > > > Christoph. > > > > I had the impression that he didn't want it in, but instead wanted each > > driver to be changed separately. > > I do think that would be a better approach. Apart from the cleanliness > issue, the driver-by-driver conversion would make it much easier to hunt > down any regresions or various funnineses. >
Actually, I disagree with driver by driver ease of hunting down regressions. Perhaps a regression is caused by having two different drivers have their tasklets converted to work queues. Or where their might be any case a tasklet is somehow related to another tasklet.
Switching all tasklets at once can pin point the problem rather quickly. Then it's easy to find which driver was the culprit.
-- Steve
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |