Messages in this thread | | | Date | Wed, 20 Jun 2007 20:16:38 +0000 | From | Pavel Machek <> | Subject | Re: [PATCH] blink: Only blink when parameter is set |
| |
Hi!
> This patch in the blink driver changes the module to only blink when > the parameter 'blink' is set to true. This is to allow the module to > be compiled in the kernel and not as module. > > As the blink module was initially written for kdump, and as the kernel > is relocatable on lots of architectures, there's no need to compile a > separate kdump kernel. The blinking can now enabled via the boot > command line for the kdump kernel when necessary. > > The patch also adds some author/license information and marks the init > function as '__init'. > > Signed-off-by: Bernhard Walle <bwalle@suse.de>
Patch looks good (and needed!) to me, but:
can we remove that driver, instead?
* It breaks keyboards. Yes, we are talking about maybe-broken i8042s, but it still breaks thinkpads at least.
* It can be done in userspace. setleds +num; sleep 1; setleds -num < /dev/tty1 does not seem like rocket science to me.
* if we want to do this, perhaps we should use proper led interface (/sys/class/led) that can already auto-blink
Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |