lkml.org 
[lkml]   [2007]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] blink: Only blink when parameter is set
    This patch in the blink driver changes the module to only blink when
    the parameter 'blink' is set to true. This is to allow the module to
    be compiled in the kernel and not as module.

    As the blink module was initially written for kdump, and as the kernel
    is relocatable on lots of architectures, there's no need to compile a
    separate kdump kernel. The blinking can now enabled via the boot
    command line for the kdump kernel when necessary.

    The patch also adds some author/license information and marks the init
    function as '__init'.

    Signed-off-by: Bernhard Walle <bwalle@suse.de>

    ---
    drivers/misc/blink.c | 13 ++++++++++++-
    1 file changed, 12 insertions(+), 1 deletion(-)

    --- a/drivers/misc/blink.c
    +++ b/drivers/misc/blink.c
    @@ -3,6 +3,10 @@
    #include <linux/timer.h>
    #include <linux/jiffies.h>

    +static int blink = 0;
    +module_param(blink, bool, S_IRUGO);
    +MODULE_PARM_DESC(blink, "Enable blinking (without that, the module does nothing)\n");
    +
    static void do_blink(unsigned long data);

    static DEFINE_TIMER(blink_timer, do_blink, 0 ,0);
    @@ -19,9 +23,16 @@ static void do_blink(unsigned long data)
    static int blink_init(void)
    {
    printk(KERN_INFO "Enabling keyboard blinking\n");
    - do_blink(0);
    +
    + if (blink)
    + do_blink(0);
    +
    return 0;
    }

    module_init(blink_init);

    +MODULE_LICENSE("GPL");
    +MODULE_AUTHOR("Andi Kleen <ak@suse.de>");
    +MODULE_DESCRIPTION("Blinks the keyboard LEDs");
    +
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-06-17 10:43    [W:2.837 / U:0.956 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site