Messages in this thread | | | Date | Fri, 15 Jun 2007 13:08:11 +0200 (MEST) | From | Mikael Pettersson <> | Subject | Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures |
| |
On Fri, 15 Jun 2007 12:43:01 +0200, Arnd Bergmann wrote: > On Friday 15 June 2007, Mikael Pettersson wrote: > > > --- linux-2.6.22-rc4-fixed/fs/quota.c.orig=A0=A0=A0=A02007-06-14 15:55:= > 26.000000000 +0400 > > > +++ linux-2.6.22-rc4-fixed/fs/quota.c=A02007-06-14 19:50:13.000000000 += > 0400 > > ... > > > +#if defined(CONFIG_X86_64) || defined(CONFIG_IA64) > > > +/* > > > + * This code works only for 32 bit quota tools over 64 bit OS (x86_64,= > ia64) > > > + * and is necessary due to alignment problems. > > > + */ > >=20 > > The #ifdef looks way too arch-specific. And isn't there a shared > > compat.c module somewhere that this should go into? > >=20 > > Only x86_64 and ia64 have this particular problem, the other architectures, > and hopefully all future 64 bit platforms with 32 bit user space use > the same alignment rules in elf32 and elf64.
Ah yes, alignof(u64) is the same in 32- and 64-bit modes on !x86, thus they don't have a problem here.
Thanks for explaining that. I consider this is an essential piece of information that should be included in the patch. (In a comment in the code, not buried in some commit log.)
/Mikael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |