| Date | Wed, 7 Mar 2007 20:22:57 +0530 | From | Srivatsa Vaddagiri <> | Subject | Re: [PATCH 2/7] containers (V7): Cpusets hooked into containers |
| |
On Mon, Feb 12, 2007 at 12:15:23AM -0800, menage@google.com wrote: > - mutex_lock(&callback_mutex); > - list_add(&cs->sibling, &cs->parent->children); > + cont->cpuset = cs; > + cs->container = cont; > number_of_cpusets++; > - mutex_unlock(&callback_mutex);
What's the rule to read/write number_of_cpusets? The earlier cpuset code was incrementing/decrementing under callback_mutex, but now we aren't. How safe is that?
The earlier cpuset code also was reading number_of_cpusets w/o the callback_mutex held (atleast in cpuset_zone_allowed_softwall). Is that safe?
-- Regards, vatsa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|