Messages in this thread | | | Subject | RE: [RFC][PATCH 00/12] md raid acceleration and performance analysis | Date | Tue, 6 Feb 2007 15:49:03 -0800 | From | "Leech, Christopher" <> |
| |
Hi Dan,
I've been looking over how your patches change the ioatdma driver. I like the idea of removing the multiple entry points for virtual address vs. page struct arguments, and just using dma_addr_t for the driver interfaces.
But, I don't think having both ioatdma and iop-adma implement map_page, map_single, unmap_page, and unmap_single entry points is much better. Do you see a reason why it wouldn't work to expose the generic device for a DMA channel, and replace instances of
dma_device->map_single(dma_chan, src, len, DMA_TO_DEVICE)
with
dma_map_single(dma_device->dev, src, len, DMA_TO_DEVICE)
I am a little concerned about having the DMA mapping happen outside of the driver, but the unmapping is still in the driver cleanup routine. I'm not sure if it's really a problem, or how I'd change it though.
- Chris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |