Messages in this thread | | | Date | Tue, 6 Feb 2007 23:13:14 +0100 | From | Adrian Bunk <> | Subject | hostap_cs_{resume,suspend}(): inconsequent NULL checking |
| |
The Coverity checker spotted the following in drivers/net/wireless/hostap/hostap_cs.c:
<-- snip -->
... static int hostap_cs_suspend(struct pcmcia_device *link) { struct net_device *dev = (struct net_device *) link->priv; int dev_open = 0; struct hostap_interface *iface = NULL;
if (dev) iface = netdev_priv(dev);
PDEBUG(DEBUG_EXTRA, "%s: CS_EVENT_PM_SUSPEND\n", dev_info); if (iface && iface->local) dev_open = iface->local->num_dev_open > 0; if (dev_open) { netif_stop_queue(dev); netif_device_detach(dev); } prism2_suspend(dev);
return 0; }
static int hostap_cs_resume(struct pcmcia_device *link) { struct net_device *dev = (struct net_device *) link->priv; int dev_open = 0; struct hostap_interface *iface = NULL;
if (dev) iface = netdev_priv(dev);
PDEBUG(DEBUG_EXTRA, "%s: CS_EVENT_PM_RESUME\n", dev_info);
if (iface && iface->local) dev_open = iface->local->num_dev_open > 0;
prism2_hw_shutdown(dev, 1); prism2_hw_config(dev, dev_open ? 0 : 1); if (dev_open) { netif_device_attach(dev); netif_start_queue(dev); }
return 0; } ...
<-- snip -->
The problem is that if the "if (dev)" is false, there's a guaranteed NULL dereference later in the "prism2_suspend(dev)" resp. "prism2_hw_config(dev, dev_open ? 0 : 1)".
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |