Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR | Date | Mon, 19 Feb 2007 11:27:33 +0000 |
| |
Oleg Nesterov <oleg@tv-sign.ru> wrote:
> Afaics, noautorel work_struct buys nothing for "struct net_bridge_port".
You may be right.
> If del_nbp()->cancel_delayed_work(&p->carrier_check) fails, port_carrier_check > may be called later anyway.
Called by what? Something outside of br_if.c?
> So the reading of *work in port_carrier_check() is equally unsafe with or > without this patch.
Hmmm... cancel_delayed_work() in del_nbp() probably ought to be followed by a flush_scheduled_work().
David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |