Messages in this thread | | | Date | Mon, 19 Feb 2007 18:04:45 +0300 | From | Oleg Nesterov <> | Subject | Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR |
| |
On 02/19, Jarek Poplawski wrote: > > On Mon, Feb 19, 2007 at 03:03:53PM +0300, Oleg Nesterov wrote: > > On 02/19, Jarek Poplawski wrote: > ... > > kfree() doesn't check WORK_STRUCT_PENDING, it makes no > > difference if it is set or not when work->func() runs. > > It looks like it's to be checked before kfree.
Here, br_add_if:
schedule_delayed_work(&p->carrier_check, BR_PORT_DEBOUNCE);
schedule_delayed_work() fails if this bit is set. So the only difference with this patch is:
before: schedule_delayed_work() fails unless port_carrier_check() passed work_release() (before rtnl_lock())
after: schedule_delayed_work() fails unless run_workqueue() cleared this bit (before calling port_carrier_check())
> > We are going to kill _NAR stuff. > > If you're sure nobody uses this in any way then it > seems the right decision.
Yes, this series converts all users.
Oleg.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |