Messages in this thread | | | From | Marc St-Jean <> | Subject | Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git mast er | Date | Fri, 16 Feb 2007 08:30:28 -0800 |
| |
Andrew Morton wrote: > On Thu, 15 Feb 2007 13:26:29 -0600 > Marc St-Jean <stjeanma@pmc-sierra.com> wrote: > > > + status = *(volatile u32 *)up->port.private_data; > > It distresses me that this patch uses a variable which this patch > doesn't initialise anywhere. It isn't complete. > > The sub-driver code whch sets up this field shuld be included in the > patch, no? >
OK, I'll re-post with the platform file which initializes the variable. That file however will reference other files in the platform which has not been posted yet. I thought it was better to post the driver-only code.
Marc - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |