Messages in this thread Patch in this message | | | Date | Sun, 11 Feb 2007 00:50:52 +0300 | From | Oleg Nesterov <> | Subject | [PATCH 3/3] ipvs: flush defense_work before module unload |
| |
net/ipv4/ipvs/ip_vs_core.c
module_exit ip_vs_cleanup ip_vs_control_cleanup cancel_rearming_delayed_work // done
This is unsafe. The module may be unloaded and the memory may be freed while defense_work's handler is still running/preempted.
Do flush_work(&defense_work.work) after cancel_rearming_delayed_work().
Alternatively, we could add flush_work() to cancel_rearming_delayed_work(), but note that we can't change cancel_delayed_work() in the same manner because it may be called from atomic context.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- 6.20-rc6-mm3/net/ipv4/ipvs/ip_vs_ctl.c~3_ipvs 2007-02-03 20:41:11.000000000 +0300 +++ 6.20-rc6-mm3/net/ipv4/ipvs/ip_vs_ctl.c 2007-02-10 23:14:41.000000000 +0300 @@ -2387,6 +2387,7 @@ void ip_vs_control_cleanup(void) EnterFunction(2); ip_vs_trash_cleanup(); cancel_rearming_delayed_work(&defense_work); + flush_work_keventd(&defense_work.work); ip_vs_kill_estimator(&ip_vs_stats); unregister_sysctl_table(sysctl_header); proc_net_remove("ip_vs_stats"); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |