Messages in this thread | | | Date | Mon, 3 Dec 2007 22:54:35 +1100 | From | Herbert Xu <> | Subject | Re: [PATCH 3/3] [UDP6]: Counter increment on BH mode |
| |
On Mon, Dec 03, 2007 at 02:49:12PM +0300, Alexey Kuznetsov wrote: > On Mon, Dec 03, 2007 at 10:39:35PM +1100, Herbert Xu wrote: > > So we need to fix this, and whatever the fix is will probably render > > the BH/USER distinction obsolete. > > Hmm, I would think opposite. USER (or generic) is expensive variant, > BH is lite. No?
Yes that would certainly be the obvious fix. In other words, just use smp_processor_id instead of the raw version. I suppose the only issue would be that disabling/enabling preemption isn't exactly cost-free and we're going to be doing that for every single increment.
Hmm, wasn't someone else talking about a non-atomic version of atomic ops lately (i.e., atomic with respect to the local CPU only)? Perhaps this is the killer app for it :)
Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |