Messages in this thread Patch in this message | | | Subject | [patch 2/2] clone: prepare to recycle CLONE_DETACHED and CLONE_STOPPED | From | akpm@linux-fo ... | Date | Thu, 08 Nov 2007 13:31:43 -0800 |
| |
From: Andrew Morton <akpm@linux-foundation.org>
Ulrich says that we never used these clone flags and that nothing should be using them.
As we're down to only a single bit left in clone's flags argument, let's add a warning to check that no userspace is actually using these. Hopefully we will be able to recycle them.
Cc: Ulrich Drepper <drepper@redhat.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Roland McGrath <roland@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> ---
kernel/fork.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-)
diff -puN kernel/fork.c~clone-prepare-to-recycle-clone_detached-and-clone_stopped kernel/fork.c --- a/kernel/fork.c~clone-prepare-to-recycle-clone_detached-and-clone_stopped +++ a/kernel/fork.c @@ -1420,10 +1420,18 @@ long do_fork(unsigned long clone_flags, int trace = 0; long nr; - if (unlikely(current->ptrace)) { - trace = fork_traceflag (clone_flags); - if (trace) - clone_flags |= CLONE_PTRACE; + /* + * We hope to recycle these flags after 2.6.26 + */ + if (unlikely(clone_flags & (CLONE_DETACHED|CLONE_STOPPED))) { + if (printk_ratelimit()) { + char comm[TASK_COMM_LEN]; + + printk(KERN_INFO "fork(): process `%s' used deprecated " + "clone flags 0x%lx\n", + get_task_comm(comm, current), + clone_flags & (CLONE_DETACHED|CLONE_STOPPED)); + } } p = copy_process(clone_flags, stack_start, regs, stack_size, _ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |