Messages in this thread Patch in this message | | | Date | Sun, 4 Nov 2007 22:32:21 +0300 | From | Oleg Nesterov <> | Subject | [PATCH] cfq: fix IOPRIO_CLASS_IDLE accounting |
| |
(untested, needs an ack from maintainer)
Spotted by Nick <gentuu@gmail.com>, hopefully can explain the second trace in http://bugzilla.kernel.org/show_bug.cgi?id=9180.
If ->async_idle_cfqq != NULL cfq_put_async_queues() puts it IOPRIO_BE_NR times in a loop. Fix this.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- cfq/block/cfq-iosched.c~ 2007-08-09 19:59:26.000000000 +0400 +++ cfq/block/cfq-iosched.c 2007-11-04 22:23:42.000000000 +0300 @@ -2065,9 +2065,10 @@ static void cfq_put_async_queues(struct cfq_put_queue(cfqd->async_cfqq[0][i]); if (cfqd->async_cfqq[1][i]) cfq_put_queue(cfqd->async_cfqq[1][i]); - if (cfqd->async_idle_cfqq) - cfq_put_queue(cfqd->async_idle_cfqq); } + + if (cfqd->async_idle_cfqq) + cfq_put_queue(cfqd->async_idle_cfqq); } static void cfq_exit_queue(elevator_t *e) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |