Messages in this thread Patch in this message | | | Date | Fri, 30 Nov 2007 09:20:34 +0800 | From | "rae l" <> | Subject | Re: [PATCH] [RESEND] crypto test: use print_hex_dump from kernel.h instead |
| |
On Nov 29, 2007 7:13 PM, Herbert Xu <herbert@gondor.apana.org.au> wrote: ... > > uninlining this function shrinks crypto/tcrypt.o's .text from 20,009 bytes > > down to 19,701. > > > > inlining is almost always wrong. > > I agree. Please do as Andrew suggests and resubmit. inline disabled.
Cc: Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by: Denis Cheng <crquan@gmail.com> ---
diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c index 24141fb..13efc72 100644 --- a/crypto/tcrypt.c +++ b/crypto/tcrypt.c @@ -83,10 +83,9 @@ static char *check[] = {
static void hexdump(unsigned char *buf, unsigned int len) { - while (len--) - printk("%02x", *buf++); - - printk("\n"); + print_hex_dump(KERN_CONT, "", DUMP_PREFIX_OFFSET, + 16, 1, + buf, len, false); }
static void tcrypt_complete(struct crypto_async_request *req, int err) -- Denis Cheng - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |