Messages in this thread | | | Date | Thu, 29 Nov 2007 22:13:24 +1100 | From | Herbert Xu <> | Subject | Re: [PATCH] [RESEND] crypto test: use print_hex_dump from kernel.h instead |
| |
On Tue, Nov 27, 2007 at 01:26:22AM -0800, Andrew Morton wrote: > On Tue, 27 Nov 2007 13:03:29 +0800 "rae l" <crquan@gmail.com> wrote: > > > -static void hexdump(unsigned char *buf, unsigned int len) > > +static inline void hexdump(unsigned char *buf, unsigned int len) > > { > > - while (len--) > > - printk("%02x", *buf++); > > - > > - printk("\n"); > > + print_hex_dump(KERN_CONT, "", DUMP_PREFIX_OFFSET, > > + 16, 1, > > + buf, len, false); > > } > > uninlining this function shrinks crypto/tcrypt.o's .text from 20,009 bytes > down to 19,701. > > inlining is almost always wrong.
I agree. Please do as Andrew suggests and resubmit.
Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |