Messages in this thread Patch in this message | | | Date | Thu, 29 Nov 2007 18:53:39 +0000 | From | Jaime Velasco Juan <> | Subject | Re: Add the infamous Huawei E220 to option.c |
| |
Hi,
El jue. 29 de nov. de 2007, a las 15:05:50 +0100, Johann Wilhelm escribió: > If everything's working please also add code to also support the other E220 > device... so both PID 0x1003 and 0x1004 should be treaded the same way... > > to test the device with the 0x1004-PID maybe Jaime Velasco > <jsagarribay@gmail.com> could be asked.. he initialy added the lines for > this device in option.c >
The following patch works for me (on kernel 2.6.23).
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index a18659e..352c94c 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -158,8 +158,8 @@ static struct usb_device_id option_ids[] = { { USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_ETNA_KOI_MODEM) }, { USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_ETNA_KOI_NETWORK) }, { USB_DEVICE(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E600) }, - { USB_DEVICE(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220) }, - { USB_DEVICE(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220BIS) }, + { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220, 0xff, 0xff, 0xff) }, + { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220BIS, 0xff, 0xff, 0xff) }, { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, 0x1100) }, /* Novatel Merlin XS620/S640 */ { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, 0x1110) }, /* Novatel Merlin S620 */ { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, 0x1120) }, /* Novatel Merlin EX720 */ > 73 > > Zitat von Oliver Neukum <oliver@neukum.org>: > >> Am Donnerstag 29 November 2007 schrieb Rui Santos: >>> >> Just to remember that that specific flag was one SET and, was removed, >>> >> in part, because of what I state. Of course we aim at perfection but, if >>> >> the benefits are only for a few situations and, will cause all this >>> >> problems for all other, perhaps the reinsert of that flag would be a >>> >> positive action. >>> >> >>> > >>> > OK, can you provide "lsusb -v" for the device in the CD mode and in >>> > the modem mode? >>> > >>> Of course. Heri it is. >> >> Thanks. Please try this patch. >> >> Regards >> Oliver >> >> ---- >> >> --- a/drivers/usb/serial/option.c 2007-11-29 12:35:09.000000000 +0100 >> +++ b/drivers/usb/serial/option.c 2007-11-29 12:47:34.000000000 +0100 >> @@ -158,7 +158,7 @@ static struct usb_device_id option_ids[] >> { USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_ETNA_KOI_MODEM) }, >> { USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_ETNA_KOI_NETWORK) }, >> { USB_DEVICE(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E600) }, >> - { USB_DEVICE(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220) }, >> + { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220, >> 0xff, 0xff, 0xff) }, >> { USB_DEVICE(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220BIS) }, >> { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, 0x1100) }, /* Novatel Merlin >> XS620/S640 */ >> { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, 0x1110) }, /* Novatel Merlin >> S620 */ >> >> > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |