Messages in this thread | | | From | Frank Seidel <> | Subject | Re: [RFC 6/13] Char: nozomi, reorder and cleanup probe, remove | Date | Sat, 10 Nov 2007 16:42:07 +0100 |
| |
On Samstag 10 November 2007 00:46:51, you (Jiri Slaby) wrote: > nozomi, reorder and cleanup probe, remove > - remap space after requesting region, to not map something we cannot use > anyway > - init spin lock before request_irq, because due to shared irq debug, isr > might be called immediately, where the lock is being held > - remove INIT_LIST_HEAD before list_add, it's useless, because list_add > re-sets prev and next > - reorder cleanup to be the same as fail path of probe (or in other words, > the reverse of probe) > - no need to call nozomi_setup_private_data in remove, pointers are set in > probe
All perfect catches IMHO. Applied without changes.
Thanks, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |