Messages in this thread | | | From | Frank Seidel <> | Subject | Re: [RFC 5/13] Char: nozomi, ioctls cleanup | Date | Sat, 10 Nov 2007 16:41:58 +0100 |
| |
On Samstag 10 November 2007 00:46:11, you (Jiri Slaby) wrote: > nozomi, ioctls cleanup > > - init tty_wait > - don't forget to wake up tiocmiwait waiters > - convert the whole tiocmiwait into wait_event_interruptible > - don't check for cmd == TIOCGICOUNT in ntty_ioctl_tiocgicount, as it's > expected to be it when we call the function, also pass internal > structures (port, argp) directly instead of ioctl params > - remove TIOCMGET, TIOCMSET, TIOCMBIC, TIOCMBIS as it is never invoked by > tty layer this way, add ntty_tiocmget into tty ops instead
Sadfully my knowledge of the tty layer is still too low to comment anything usefull, but all sound and looks reasonable to me. And i did a special testrun after this patch and couldn't see any problems.
So, applied without change.
Thanks, Frank
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |