lkml.org 
[lkml]   [2007]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3/3] drivers/ide/pci/sc1200.c: fix suspend/resume buglets and warnings
Date
On Thursday 25 October 2007, Jeff Garzik wrote:
> * We shouldn't bother with dev->current_state, the PCI API functions we
> call manage this for us (and do a far better job at it too).
>
> * Remove pci_set_power_state(dev, PCI_D0) call in resume, as
> pci_enable_device() does the same thing.
>
> * Check pci_enable_device() return value. If it failed, fail
> the entire resume and avoid programming timings into the [potentially
> dead/asleep] chip.
>
> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

applied, thanks
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-10-25 22:11    [W:0.291 / U:0.864 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site