Messages in this thread | | | Date | Thu, 25 Oct 2007 01:09:50 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH 1/4] [SCSI] ips: remove ips_ha members that duplicate struct pci_dev members |
| |
Andrew Morton wrote: > On Wed, 24 Oct 2007 19:48:26 -0400 (EDT) Jeff Garzik <jeff@garzik.org> wrote: > >> drivers/scsi/ips.c | 178 ++++++++++++++++++++++++---------------------------- > > this driver seems a bit of a basket case :( > > > What's going on here? > > scb->dcdb.cmd_attribute = > ips_command_direction[scb->scsi_cmd->cmnd[0]]; > > /* Allow a WRITE BUFFER Command to Have no Data */ > /* This is Used by Tape Flash Utilites */ > if ((scb->scsi_cmd->cmnd[0] == WRITE_BUFFER) && (scb->data_len == 0)) > scb->dcdb.cmd_attribute = 0; > > if (!(scb->dcdb.cmd_attribute & 0x3)) > scb->dcdb.transfer_length = 0; > > if (scb->data_len >= IPS_MAX_XFER) { > > I hope that's just busted indentation and not a missing {} block.
The driver is one of the grotty drivers people are afraid to touch, therefore it bitrots even faster, in a vicious cycle. You don't have to look hard at all to find checkpatch pukeage, very real bugs, and Pythonesque silliness.
Not having hardware I went only for changes that are provable and obvious, really...
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |