Messages in this thread | | | Date | Wed, 24 Oct 2007 13:58:47 -0600 | From | Matthew Wilcox <> | Subject | Stringbuf, v2 |
| |
Incorporated all feedback received:
- Explicitly allow people to dereference sb->buf and sb->len, and include comments about the potential problems with doing so. Document that alloc is probably better left unreferenced. Remove sb_len() and sb_string(). - Ensure that we grow by at least 1.5x, even if we're using slob. - Start by allocating 128 bytes - Pass a gfp_t to sb_printk - Drop the bogus change to snd_ac97_proc_regs_write - Add stringbuf.o to obj-y instead of lib-y, otherwise a fully modular kernel might not pull in sb_printf
-- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |