Messages in this thread Patch in this message | | | Subject | [Patch] Possible dereference in fs/nfsd/nfs4callback.c | From | Eric Sesterhenn <> | Date | Tue, 26 Sep 2006 12:30:59 +0200 |
| |
hi,
the following commit introduced a possible NULL pointer dereference http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ae5c79476f36512d1100e162606bb5691f2cce5a
we set cb->cb_client to NULL and pass it to rpc_shutdown_client() which dereferences it. The easy fix below.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.18-git5/fs/nfsd/nfs4callback.c.orig 2006-09-26 12:24:23.000000000 +0200 +++ linux-2.6.18-git5/fs/nfsd/nfs4callback.c 2006-09-26 12:24:40.000000000 +0200 @@ -450,7 +450,8 @@ out_rpciod: rpciod_down(); cb->cb_client = NULL; out_clnt: - rpc_shutdown_client(cb->cb_client); + if (cb->cb_client) + rpc_shutdown_client(cb->cb_client); out_err: dprintk("NFSD: warning: no callback path to client %.*s\n", (int)clp->cl_name.len, clp->cl_name.data);
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |