Messages in this thread Patch in this message | | | Date | Wed, 20 Sep 2006 15:57:30 +0200 | From | Martin Schwidefsky <> | Subject | [S390] hypfs crashes with invalid mount option. |
| |
From: Michael Holzheu <holzheu@de.ibm.com>
[S390] hypfs crashes with invalid mount option.
When an invalid mount option is specified, no root inode is created for hypfs, hypfs_fill_super() returns with -EINVAL and then hypfs_kill_super() is called. hypfs_kill_super() does not check if the root inode has been initialized. This patch adds this check.
Signed-off-by: Michael Holzheu <holzheu@de.ibm.com> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com> ---
arch/s390/hypfs/inode.c | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-)
diff -urpN linux-2.6/arch/s390/hypfs/inode.c linux-2.6-patched/arch/s390/hypfs/inode.c --- linux-2.6/arch/s390/hypfs/inode.c 2006-09-20 15:52:40.000000000 +0200 +++ linux-2.6-patched/arch/s390/hypfs/inode.c 2006-09-20 15:53:15.000000000 +0200 @@ -312,10 +312,12 @@ static void hypfs_kill_super(struct supe { struct hypfs_sb_info *sb_info = sb->s_fs_info; - hypfs_delete_tree(sb->s_root); - hypfs_remove(sb_info->update_file); - kfree(sb->s_fs_info); - sb->s_fs_info = NULL; + if (sb->s_root) { + hypfs_delete_tree(sb->s_root); + hypfs_remove(sb_info->update_file); + kfree(sb->s_fs_info); + sb->s_fs_info = NULL; + } kill_litter_super(sb); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |