Messages in this thread | | | Date | Thu, 14 Sep 2006 09:30:48 -0500 | From | Dimitri Sivanich <> | Subject | Re: [PATCH] Migration of standard timers |
| |
Hi Jes,
On Thu, Sep 14, 2006 at 10:11:39AM -0400, Jes Sorensen wrote: > Hi Dimitri, > > I just took a quick look at your patch, and at least on the surface it > looks pretty nice to me. > > One minor nit, why choose short for the affinity field in struct > timer_list, it seems a strange size to pick for something which is > either 0 or 1. Wouldn't int or char be better? I don't know if all > CPUs have 16 bit stores, but they should have 8 and 32 bit.
Yes, you're probably right. I would have no problem with this being changed to a 'char'.
> > The name 'aff' for affinity might not be good either, since we tend to > refer to affinity as a mask specifying where it's locked to, maybe > 'locked' would be better?
A field name of 'locked' would be OK with me.
> > All in the nit-picking department though. > > Cheers, > Jes > > > Index: linux/include/linux/timer.h > =================================================================== > --- linux.orig/include/linux/timer.h > +++ linux/include/linux/timer.h > @@ -15,6 +15,8 @@ struct timer_list { > unsigned long data; > > struct tvec_t_base_s *base; > + > + short aff; > }; > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |